[Oisf-devel] [PATCH 0/8] Misc code cleaning

Eric Leblond eleblond at edenwall.com
Mon Jan 11 10:11:30 UTC 2010


This patchset contains mainly patches that could be called code
cleaning. Some of them are just humble proposal that reflect some
particular coding style I'm used to see in some places.

The only fixed issue is provided by 
    [PATCH 1/8] Fix typo in Makefile.am
which fixes 'make tag' command

The two next patches are a proposal, they only suggest using 'switch'
construction instead of 'else if':
    [PATCH 2/8] ethernet: use switch instead of 'else if'
    [PATCH 3/8] nfq: use switch instead of 'else if'

Patch 4 suppresses some TODO by fixing them:
    [PATCH 4/8] nfq: add sanity checking

The rest of the patchset is relative to using -Wextra during compilation
to benefit from all gcc warnings. I was quiet impressed that there was
almost any warning in this mode !

    [PATCH 5/8] configure: compile with -Wextra
    [PATCH 6/8] convert action_type to enum
    [PATCH 7/8] gcc warning fixes.
    [PATCH 8/8] fix code file permission

BR,
--
Eric Leblond <eleblond at edenwall.com>



More information about the Oisf-devel mailing list