[Oisf-devel] [PATCH 0/8] Misc code cleaning

[Kirby Kuehl]

I have taken Eric's work and attached it as a unified diff. I made no other
changes, but I thought this would be easier to apply than to cut and paste
out of emails. Thanks Eric!

- Kirby Kuehl

On Mon, Jan 11, 2010 at 7:27 AM, Will Metcalf <william.metcalf at gmail.com>wrote:

> Eric,
>
> Wow!  Thanks for the patches.  We will have a look and work on getting them
> integrated as needed into the current version of the code in the public git
> repo. ;-).
>
> Regards,
>
> Will
>
>
> On Mon, Jan 11, 2010 at 4:11 AM, Eric Leblond <eleblond at edenwall.com>wrote:
>
>>
>> This patchset contains mainly patches that could be called code
>> cleaning. Some of them are just humble proposal that reflect some
>> particular coding style I'm used to see in some places.
>>
>> The only fixed issue is provided by
>>    [PATCH 1/8] Fix typo in Makefile.am
>> which fixes 'make tag' command
>>
>> The two next patches are a proposal, they only suggest using 'switch'
>> construction instead of 'else if':
>>    [PATCH 2/8] ethernet: use switch instead of 'else if'
>>    [PATCH 3/8] nfq: use switch instead of 'else if'
>>
>> Patch 4 suppresses some TODO by fixing them:
>>    [PATCH 4/8] nfq: add sanity checking
>>
>> The rest of the patchset is relative to using -Wextra during compilation
>> to benefit from all gcc warnings. I was quiet impressed that there was
>> almost any warning in this mode !
>>
>>    [PATCH 5/8] configure: compile with -Wextra
>>    [PATCH 6/8] convert action_type to enum
>>    [PATCH 7/8] gcc warning fixes.
>>    [PATCH 8/8] fix code file permission
>>
>> BR,
>> --
>> Eric Leblond <eleblond at edenwall.com>
>> _______________________________________________
>> Oisf-devel mailing list
>> Oisf-devel at openinfosecfoundation.org
>> http://lists.openinfosecfoundation.org/mailman/listinfo/oisf-devel
>>
>
>
> _______________________________________________
> Oisf-devel mailing list
> Oisf-devel at openinfosecfoundation.org
> http://lists.openinfosecfoundation.org/mailman/listinfo/oisf-devel
>
>


-- 
PGP Fingerprint: 8784 EAFE E9C5 D083 3E81  727C F265 5AEF E6F8 A671
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openinfosecfoundation.org/pipermail/oisf-devel/attachments/20100111/9b3be2f4/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-patch-from-Eric-Leblond.patch
Type: application/octet-stream
Size: 8933 bytes
Desc: not available
URL: <http://lists.openinfosecfoundation.org/pipermail/oisf-devel/attachments/20100111/9b3be2f4/attachment.obj>