[Oisf-devel] problem with build / configure.ac on OpenBSD 5.9 -current

[Jason Ish]

On Sun, May 15, 2016 at 3:19 PM, Markus Lude <markus.lude at gmx.de> wrote:
> On Sat, May 07, 2016 at 08:41:21PM -0600, Jason Ish wrote:
>> On Sat, May 7, 2016 at 9:37 AM, Markus Lude <markus.lude at gmx.de> wrote:
>> > On Sun, Apr 17, 2016 at 05:33:50PM +0200, Markus Lude wrote:
>> >> Hello,
>> >>
>> >> today I tried to build a package for suricata 3.0.1 on OpenBSD 5.9
>> >> -current.
>> >>
>> >> build stopped with:
>> >>
>> >> [...]
>> >> Making all in test
>> >> Making all in docs
>> >> Making all in src
>> >> make  all-am
>> >> cc -DHAVE_CONFIG_H -I. -I/usr/obj/ports/suricata-3.0.1/suricata-3.0.1/src -I..    -I/usr/obj/ports/suricata-3.0.1/suricata-3.0.1/../libhtp/  -I/usr/local/include -I/usr/local/include/libnet-1.1 -I/usr/local/include/libnet-1.1 -I/usr/local/include/nspr  -Wextra -Werror-implicit-function-declaration -fno-tree-pre     -Wall -Wno-unused-parameter  -std=gnu99 -DLOCAL_STATE_DIR=\"/var\"  -ggdb -O0 -O2 -pipe -D__OpenBSD__ -MT alert-debuglog.o -MD -MP -MF .deps/alert-debuglog.Tpo -c -o alert-debuglog.o /usr/obj/ports/suricata-3.0.1/suricata-3.0.1/src/alert-debuglog.c
>> >> In file included from /usr/obj/ports/suricata-3.0.1/suricata-3.0.1/src/alert-debuglog.c:24:
>> >> /usr/obj/ports/suricata-3.0.1/suricata-3.0.1/src/suricata-common.h:336:21: error: htp/htp.h: No such file or directory
>> >>
>> >> suricata-common.h:
>> >>
>> >>    335
>> >>    336  #include <htp/htp.h>
>> >>    337  #include "threads.h"
>> >>
>> >> the following search path for includes above seems wrong:
>> >> -I/usr/obj/ports/suricata-3.0.1/suricata-3.0.1/../libhtp/
>> >>
>> >> it should be
>> >> -I/usr/obj/ports/suricata-3.0.1/suricata-3.0.1/libhtp/
>> >> instead, which exists.
>> >>
>> >>
>> >> Finally I stumbled upon this from configure.ac:
>> >>
>> >>   1232      if test "x$enable_non_bundled_htp" = "xno"; then
>> >>   1233          # test if we have a bundled htp
>> >>   1234          if test -d "$srcdir/libhtp"; then
>> >>   1235              AC_CONFIG_SUBDIRS([libhtp])
>> >>   1236              HTP_DIR="libhtp"
>> >>   1237              AC_SUBST(HTP_DIR)
>> >>   1238              HTP_LDADD="../libhtp/htp/libhtp.la"
>> >>   1239              AC_SUBST(HTP_LDADD)
>> >>   1240              # make sure libhtp is added to the includes
>> >>   1241              CPPFLAGS="-I${srcdir}/../libhtp/ ${CPPFLAGS}"
>> >>   1242
>> >>
>> >> why is the test for this block for $srcdir/libhtp and the include
>> >> search path added to CPPFLAGS is ${srcdir}/../libhtp/ ?
>> >
>> > no interest in fixing this?
>>
>> For what its worth, I've successfully built Suricata 3.0.1 and
>> Suricata git master (today) on OpenBSD 5.9. Follows is the list of
>> packages I have installed, including autoconf and automake:
>
> You may re-read my original post.
>
> The question about the code from the configure script is still
> unanswered.
>
> I consider this as works by luck.
>
>> autoconf-2.59p4
>> autoconf-2.69p1
>> automake-1.9.6p11
>> curl-7.47.0
>> cvsps-2.1p0
>> gettext-0.19.7
>> git-2.7.0
>> jansson-2.7p1
>> libiconv-1.14p3
>> libidn-1.32
>> libltdl-2.4.2p1
>> libmagic-5.25
>> libtool-2.4.2p0
>> libyaml-0.1.6p1
>> metaauto-1.0p1
>> nghttp2-1.6.0
>> p5-Error-0.17024
>> pcre-8.38
>> quirks-2.197
>> rsync-3.1.2
>> sudo-1.8.15
>
> Maybe you want to strip down this list to those packages that are needed
> to build suricata. Try to build a port for suricata.

Ok, built a port.

Just looks like $srcdir needs to be escaped. This should give us
something that works in a normal build, as well as an OpenBSD
SEPARATE_BUILD=yes.

See: https://github.com/jasonish/suricata/commit/c1fcd2a747063b0c43365460a0392c36f7637a02

Jason