<br><br>On Tuesday, October 8, 2013, Ivan Ristić wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 08/10/2013 12:55, Pierre Chifflier wrote:<br>
> On Mon, Oct 07, 2013 at 06:39:32PM +0100, Ivan Ristić wrote:<br>
>> On 07/10/2013 17:24, Victor Julien wrote:<br>
>>> On 10/07/2013 05:35 PM, Pierre Chifflier wrote:<br>
>>>> I am slowly catching up after vacation, so I have updated versions of<br>
>>>> suricata in unstable, and prepared the 2.0-beta1 in experimental.<br>
>>>><br>
>>>> The build daemons seems to have caught something, since the test suite<br>
>>>> fails on several tests on some architectures:<br>
>>>> <a href="https://buildd.debian.org/status/package.php?p=libhtp&suite=experimental" target="_blank">https://buildd.debian.org/status/package.php?p=libhtp&suite=experimental</a><br>
>>>><br>
>>>> <a href="https://buildd.debian.org/status/fetch.php?pkg=libhtp&arch=powerpc&ver=0.5.5-1&stamp=1377013001" target="_blank">https://buildd.debian.org/status/fetch.php?pkg=libhtp&arch=powerpc&ver=0.5.5-1&stamp=1377013001</a><br>
>>>> <a href="https://buildd.debian.org/status/fetch.php?pkg=libhtp&arch=s390&ver=0.5.5-1&stamp=1377013856" target="_blank">https://buildd.debian.org/status/fetch.php?pkg=libhtp&arch=s390&ver=0.5.5-1&stamp=1377013856</a><br>
>>>> <a href="https://buildd.debian.org/status/fetch.php?pkg=libhtp&arch=armel&ver=0.5.5-1&stamp=1377019860" target="_blank">https://buildd.debian.org/status/fetch.php?pkg=libhtp&arch=armel&ver=0.5.5-1&stamp=1377019860</a><br>
>>>><br>
>>>> For example:<br>
>>>> [ FAILED ] 6 tests, listed below:<br>
>>>> [ FAILED ] HybridParsing.CompressedResponse<br>
>>>> [ FAILED ] HybridParsing.CompressedResponseNoDecompression<br>
>>>> [ FAILED ] HybridParsing.ForcedDecompression<br>
>>>> [ FAILED ] HybridParsing.DisableDecompression<br>
>>>> [ FAILED ] Base64.Single<br>
>>>> [ FAILED ] Base64.Decode<br>
>>><br>
>>> Ivan has released 0.5.7, so it may be worth looking at that instead.<br>
>><br>
>> I don't think that anything I did in 0.5.7 is going to make a<br>
>> difference. I was not aware of those tests failing.<br>
>><br>
>> Do you know if there are some VM images I could use to deploy on those<br>
>> architectures?<br>
>><br>
><br>
> Hi Ivan and Victor,<br>
><br>
> Looking at the changelog it seems that 0.5.7 will not change anything, I<br>
> will try later though.<br>
<br>
No need to try with 0.5.7; it definitely won't change anything.<br>
<br>
If you do have some time and want to try again, please configure LibHTP<br>
with --enable-debug. That should produce lots of output, some of which<br>
might be useful enough to determine the cause.<br>
<br>
In the meantime, I will try to gain access to a PowerPC architecture.<br>
<br>
Thanks.<br>
<br>
<br>
> I'm afraid there is no VM available. Debian developers have access to<br>
> some porter boxes, so I will try to build the package directly on one of<br>
> the failing architectures to see if I can get some more details.<br>
><br>
> Note that the build logs give some more details on the tests output, for<br>
> ex in<br>
> <a href="https://buildd.debian.org/status/fetch.php?pkg=libhtp&arch=armhf&ver=0.5.5-1&stamp=1378587543" target="_blank">https://buildd.debian.org/status/fetch.php?pkg=libhtp&arch=armhf&ver=0.5.5-1&stamp=1378587543</a><br>
><br>
> [ RUN ] Base64.Single<br>
> test_utils.cpp:59: Failure<br>
> Value of: htp_base64_decode_single(',')<br>
> Actual: 255<br>
> Expected: -1<br>
> [ FAILED ] Base64.Single (1 ms)</blockquote><div><br></div><div>You return a char as an int and the auto conversion seems to be bitwise and not by integer value. Try explict cast to int or assign to int and return that?</div>
<div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> [ RUN ] Base64.Decode<br>
> test_utils.cpp:69: Failure<br>
> Value of: bstr_cmp_c(out, "this is a test..")<br>
> Actual: 1<br>
> Expected: 0<br>
> [ FAILED ] Base64.Decode (0 ms)</blockquote><div><br></div><div>Function Returns int, but your return values are pointer arithmetic and get auto converted. Probably needs range checks and explicit casts?<span></span><br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
><br>
> and<br>
><br>
> [ RUN ] HybridParsing.CompressedResponse<br>
> test_hybrid.cpp:512: Failure<br>
> Value of: tx->response_message_len<br>
> Actual: 189<br>
> Expected: 187<br>
><br>
> Pierre</blockquote><div><br></div><div>Looks like this may be due to the base64 issues. </div><div><br></div><div><br></div><div>-B</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
--<br>
Ivan<br>
_______________________________________________<br>
Suricata IDS Devel mailing list: <a href="javascript:;" onclick="_e(event, 'cvml', 'oisf-devel@openinfosecfoundation.org')">oisf-devel@openinfosecfoundation.org</a><br>
Site: <a href="http://suricata-ids.org" target="_blank">http://suricata-ids.org</a> | Participate: <a href="http://suricata-ids.org/participate/" target="_blank">http://suricata-ids.org/participate/</a><br>
List: <a href="https://lists.openinfosecfoundation.org/mailman/listinfo/oisf-devel" target="_blank">https://lists.openinfosecfoundation.org/mailman/listinfo/oisf-devel</a><br>
Redmine: <a href="https://redmine.openinfosecfoundation.org/" target="_blank">https://redmine.openinfosecfoundation.org/</a></blockquote><br><br>-- <br>Brian Rectanus<br>