<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Hi</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">

I checked Suricata code and I found out that decoder thread modules don't set ThreadDeinit member of their TmModule in tmm_modules table.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">

<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">It somehow doesn't seem normal. Since, decode threads have at least one member in their DecodeThreadVars which maybe should be deinitialized. Actually, I realized DecodeThreadVars  contains AlpProtoDetectThreadCtx member and the AlpProtoDetectThreadCtx variables maybe should be deinitialized by using AlpProtoFinalize2Thread function; similar what happens in StreamTcpThreadDeinit (StreamTcp thread deinitializing) procedure. </div>

<div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">According what I said, do you think the implementation of decoders' deinitialization has been missed mistakenly? or not implementing of that doesn't make any problem?</div>

<div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Thanks</div></div>