[OISF/outreachy] [outreachy] Working on new issue

[vagisha gupta]

On Tue, Mar 19, 2019 at 8:53 PM vagisha gupta <vagishagupta23 at gmail.com>
wrote:

> Hey,
>
> On Tue, Mar 19, 2019 at 12:27 AM Shivani Bhardwaj <
> sbhardwaj at openinfosecfoundation.org> wrote:
>
>> Hi, Vagisha!
>>
>> On Sun, Mar 17, 2019 at 1:27 AM vagisha gupta <vagishagupta23 at gmail.com>
>> wrote:
>> >
>> > Hi,
>> > I do not understand the part 'The imports are also scattered when they
>> can be compact' in the description of ticket #2872. Could you please
>> explain?
>> >
>> This means that the imports could have been written in a more compact
>> and pretty manner as they are now. For example, the imports like
>> from a import b
>> from a import c
>>
>> do not require to be scattered like this, they could go like
>> from a import (b, c)
>> >
>
> I do not understand whether I have to send a PR with only new changes for
> working more on this issue
> or do I have to make new changes and also show the changes which are
> approved in my previous PR?
>
 Here is the link to the previous PR:
https://github.com/OISF/suricata-update/pull/114

>
>
> > On Thu, Mar 14, 2019 at 3:04 PM vagisha gupta <vagishagupta23 at gmail.com>
>> wrote:
>> >>
>> >> Sure! I will start working under #2872
>> >>
>> >> On Thu, Mar 14, 2019 at 2:48 PM Shivani Bhardwaj <
>> sbhardwaj at openinfosecfoundation.org> wrote:
>> >>>
>> >>> On Thu, Mar 14, 2019 at 2:42 PM vagisha gupta <
>> vagishagupta23 at gmail.com> wrote:
>> >>> >
>> >>> > I found one of the imports in main.py that is not necessary anymore
>> and I want to cleanup that import.
>> >>> > But I do not know whether it will come under Optimization #2880 or
>> under Optimization #2872.
>> >>> > So, under which issue should I work on?
>> >>> >
>> >>> Please keep the import cleanups under the ticket 2872.
>> >>>
>> >>> > On Thu, Mar 14, 2019 at 2:13 PM Shivani Bhardwaj <
>> sbhardwaj at openinfosecfoundation.org> wrote:
>> >>> >>
>> >>> >> Hi, Vagisha!
>> >>> >>
>> >>> >> On Thu, Mar 14, 2019 at 2:08 PM vagisha gupta <
>> vagishagupta23 at gmail.com> wrote:
>> >>> >> >
>> >>> >> > Hi,
>> >>> >> > Since the previous PR I sent is approved can I start working on
>> a new issue?
>> >>> >> > How about Optimization #2880, Remove redundant code?
>> >>> >> Yes you can.
>> >>> >>
>> >>> >> > Can I clean up a main import under this issue?
>> >>> >> >
>> >>> >> I do not understand this part, could you please explain?
>> >>> >>
>> >>> >> > On Wed, Mar 13, 2019 at 11:53 PM Shivani Bhardwaj <
>> sbhardwaj at openinfosecfoundation.org> wrote:
>> >>> >> >>
>> >>> >> >> On Wed, Mar 13, 2019 at 10:17 PM vagisha gupta <
>> vagishagupta23 at gmail.com> wrote:
>> >>> >> >> >
>> >>> >> >> > Hi all,
>> >>> >> >> > I forgot to introduce myself. I'm Vagisha Gupta , an
>> outreachy summer 2019 applicant. I program mostly in Python, but also have
>> experience in Java, C and C#.  Also, I am new to open source. I'm excited
>> and looking forward to working with Suricata in the project Improve
>> Suricata-update..
>> >>> >> >> > I have sent a PR on bug #2869. I am looking for more issues
>> on Readmine.
>> >>> >> >> Thanks for your contribution, Vagisha.
>> >>> >> >>
>> >>> >> >> > Can I start working on Optimization #2873 if nobody is
>> working on it?
>> >>> >> >> >
>> >>> >> >> We're following one issue per applicant at a time so you'll
>> have to
>> >>> >> >> wait until your current PR is approved before claiming any other
>> >>> >> >> tasks.
>> >>> >> >>
>> >>> >> >> > On Tue, Mar 12, 2019 at 8:22 AM Shivani Bhardwaj <
>> sbhardwaj at openinfosecfoundation.org> wrote:
>> >>> >> >> >>
>> >>> >> >> >> Hi, Vagisha!
>> >>> >> >> >>
>> >>> >> >> >> On Tue, Mar 12, 2019 at 8:18 AM vagisha gupta via Outreachy
>> >>> >> >> >> <outreachy at lists.openinfosecfoundation.org> wrote:
>> >>> >> >> >> >
>> >>> >> >> >> > Hello
>> >>> >> >> >> > This is Vagisha Gupta, an Outreachy Summer 2019 applicant
>> and a postgraduate student in CSE.
>> >>> >> >> >> > I would like to work on this project as my first
>> contribution. I have already a sent  PR for bug #2869.
>> >>> >> >> >> > Can someone guide me on moving forward and contributing
>> more.
>> >>> >> >> >> >
>> >>> >> >> >> Thanks for your contribution. I would request you to follow
>> the
>> >>> >> >> >> contribution guidelines here:
>> >>> >> >> >>
>> https://www.outreachy.org/may-2019-august-2019-outreachy-internships/communities/the-open-information-security-foundation/#improve-suricata-update
>> >>> >> >> >>
>> >>> >> >> >> Please join the mailing list and always check if someone is
>> already
>> >>> >> >> >> working on the issue before sending the PR to avoid
>> redundant work.
>> >>> >> >> >> Follow rest of the points too.
>> >>> >> >> >> Rest comments on the PR.
>> >>> >> >> >>
>> >>> >> >> >> > Thanks and regards
>> >>> >> >> >> > Vagisha Gupta
>> >>> >> >> >> >
>> >>> >> >> >> > _______________________________________________
>> >>> >> >> >> > Outreachy mailing list
>> >>> >> >> >> > Outreachy at lists.openinfosecfoundation.org
>> >>> >> >> >> > https://lists.openinfosecfoundation.org/listinfo/outreachy
>> >>> >> >> >>
>> >>> >> >> >>
>> >>> >> >> >>
>> >>> >> >> >> --
>> >>> >> >> >> Shivani
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> --
>> >>> >> >> Shivani
>> >>> >>
>> >>> >>
>> >>> >>
>> >>> >> --
>> >>> >> Shivani
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Shivani
>>
>>
>>
>> --
>> Shivani
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openinfosecfoundation.org/pipermail/outreachy/attachments/20190319/89a8d911/attachment-0001.html>