[OISF/outreachy] Claiming Redmine ticket #2874

[Vidushi Agrawal]

On Thu, Mar 21, 2019 at 12:52 PM Shivani Bhardwaj <
sbhardwaj at openinfosecfoundation.org> wrote:

> Hi, Vidushi!
>
> On Thu, Mar 21, 2019 at 12:58 AM Vidushi Agrawal via Outreachy
> <outreachy at lists.openinfosecfoundation.org> wrote:
> >
> > Hi,
> >
> > I would like to start working on redmine ticket #2874. If none's working
> on it, could it be assigned to me?
> > If yes, could you please guide me how it should ideally be approached?
> Am I supposed to put all the argparse codes inside a function inside the
> class and assign arg to init?
> >
> Yes, you can.
> I haven't really thought through the different approaches. Why don't
> you start by explaining the ones you think are possible and good to
> have? Note that the goal is to make main.py less cluttered and there
> is a lot of parsers code over there so we need to get rid of that.
>
> After giving it a careful thought, I think the simplest approach would be
to put all the argparse code in a separate function and simply make a
function call from main function because the args variable is already a
global variable.
One other approach could be to make a separate class (which probably can be
used as a Namespace) with a function for argparse code and assigning args
to init.
I felt the first approach was simpler and helps to achieve our aim of
making the code cleaner and compact. I've made a PR for the same, please
review and let me know if any changes are required.
Thank you.

> > Thank you,
> > Regards,
> > Vidushi
> > _______________________________________________
> > Outreachy mailing list
> > Outreachy at lists.openinfosecfoundation.org
> > https://lists.openinfosecfoundation.org/listinfo/outreachy
>
>
>
> --
> Shivani
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openinfosecfoundation.org/pipermail/outreachy/attachments/20190323/1f6b4026/attachment.html>