[OISF/outreachy] [outreachy] Selecting issue for contribution

[Shivani Bhardwaj]

Hi, Himanshi!

On Sat, Mar 23, 2019 at 6:13 PM Himanshi Mathur
<himanshi18037 at iiitd.ac.in> wrote:
>
> Hello Ma'am
Please use the first names of people to address them. :)

> I just wanted to inform you that I am almost done with this issue but had a few doubts.
> In main.py we have class ModifyRuleFilter and class Fetch which includes function from matchers.py and also have few functions for the same. So I wanted to clarify will any of these classes also I have to integrate into matchers.py. And also after that, before uploading should I mail my contribution to you so that I can know if you expect something else too or upload it directly?
>
The whole point of bringing the matchers out is to create separation
of logic for different services. So, please make sure matchers.py only
has code particular to matchers and make appropriate imports and calls
in the main function. Please send a PR directly so that any mentor can
leave a review.

> Waiting in anticipation.
>
> On Thu, Mar 14, 2019 at 12:12 AM Shivani Bhardwaj <sbhardwaj at openinfosecfoundation.org> wrote:
>>
>> On Thu, Mar 14, 2019 at 12:09 AM Himanshi Mathur via Outreachy
>> <outreachy at lists.openinfosecfoundation.org> wrote:
>> >
>> > Sir/Ma'am
>> >  I would like to work with issue #2873 if it is not assigned to anyone else as I found it interesting?
>> Please go ahead.
>>
>> > --
>> > Thanks and regards
>> > Himanshi Mathur
>> > CSE undergrad 2022
>> > IIIT DELHI
>> > _______________________________________________
>> > Outreachy mailing list
>> > Outreachy at lists.openinfosecfoundation.org
>> > https://lists.openinfosecfoundation.org/listinfo/outreachy
>>
>>
>>
>> --
>> Shivani
>
>
>
> --
> Thanks and regards
> Himanshi Mathur
> CSE undergrad 2022
> IIIT DELHI



-- 
Shivani