[OISF/outreachy] Task #2879 help needed

[megha Varshney]

Greetings,
I made changes to main.py file such that whenever a duplicate sid is
encountered it will log a warning. I am trying testing my code, I wanted to
ask if , do I need to make changes to rule.py file if yes, what changes do
i need to make.
Regards
Megha

On Sat, 30 Mar 2019 at 00:38, Shivani Bhardwaj <
sbhardwaj at openinfosecfoundation.org> wrote:

> On Fri, Mar 29, 2019 at 10:05 PM megha Varshney
> <varshney.megha070 at gmail.com> wrote:
> >
> > Greetings,
> > Thank you so much for the above article but I was unable to test my
> code. I ain't getting from where do I need to copy the rules.
> >
> I do not understand. Could you please explain what have you done so
> far and what are you trying to achieve?
>
> > Regards,
> > Megha
> >
> > On Mon, 25 Mar 2019 at 17:13, Shivani Bhardwaj <
> sbhardwaj at openinfosecfoundation.org> wrote:
> >>
> >> Hi, Megha!
> >>
> >> On Sat, Mar 23, 2019 at 2:26 AM megha Varshney
> >> <varshney.megha070 at gmail.com> wrote:
> >> >
> >> > Greetings,
> >> > Could you please help me in testing my code?
> >>
> >> I just wrote a test routine here for you:
> >> https://gist.github.com/shivan1b/be0cee4e9edcd63f678ac806abbc0291
> >>
> >> After applying the changes, you should look for the log message that
> >> you have written in the last step on console justifying your case.
> >>
> >> Let me know if you need more help.
> >>
> >> > Regards
> >> > Megha
> >> >
> >> > On Mon, 18 Mar 2019 at 13:52, Shivani Bhardwaj <
> sbhardwaj at openinfosecfoundation.org> wrote:
> >> >>
> >> >> Hi Megha!
> >> >>
> >> >> On Sat, Mar 16, 2019 at 1:33 AM megha Varshney
> >> >> <varshney.megha070 at gmail.com> wrote:
> >> >> >
> >> >> > Greetings,
> >> >> > Do I need to include the following code snippet in build_rule_map
> function of the main.py file?
> >> >> > FORMAT = '%(version)s %(message)s'
> >> >> > logging.basicConfig(format=FORMAT)
> >> >> > d={'version: rule'}
> >> >> > logger = logging.getLogger('tcpserver')
> >> >> > logger.warning('Found duplicate rule ID %s', 'keeping one with
> higher revision')
> >> >> >
> >> >>
> >> >> Please do a "Reply-all" in all your emails so that if I am
> unavailable
> >> >> (like I was for past two days) someone else can help you. You should
> >> >> try and ask for code reviews only on the PRs you send. However, if
> you
> >> >> need any help with understanding the issue, testing routine, etc
> >> >> you're free to ask. Please make sure to have tested the code before
> >> >> you send a PR.
> >> >>
> >> >> > Regards,
> >> >> > Megha
> >> >> >
> >> >> >
> >> >> > On Fri, 15 Mar 2019 at 14:54, megha Varshney <
> varshney.megha070 at gmail.com> wrote:
> >> >> >>
> >> >> >> Thanks a lot. Will try looking for this.
> >> >> >>
> >> >> >> On Fri, 15 Mar 2019 at 14:48, Shivani Bhardwaj <
> sbhardwaj at openinfosecfoundation.org> wrote:
> >> >> >>>
> >> >> >>> On Fri, Mar 15, 2019 at 2:38 PM megha Varshney via Outreachy
> >> >> >>> <outreachy at lists.openinfosecfoundation.org> wrote:
> >> >> >>> >
> >> >> >>> > Greetings,
> >> >> >>> > I read the documentation and tried understanding the code
> snippets but I couldn't get, where do I need to start in order to complete
> the task assigned.
> >> >> >>> >
> >> >> >>> Maybe this will be helpful to know what sid is:
> >> >> >>>
> https://suricata.readthedocs.io/en/suricata-4.1.2/rules/meta.html#sid-signature-id
> >> >> >>> As Jason had mentioned in the issue that it has already been
> >> >> >>> implemented, your task is to look up the code of suricata-update
> and
> >> >> >>> see where sids are being processed for duplicate IDs.
> >> >> >>> Does this make sense?
> >> >> >>>
> >> >> >>> > Regards,
> >> >> >>> > Megha Varshney
> >> >> >>> > _______________________________________________
> >> >> >>> > Outreachy mailing list
> >> >> >>> > Outreachy at lists.openinfosecfoundation.org
> >> >> >>> > https://lists.openinfosecfoundation.org/listinfo/outreachy
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>> --
> >> >> >>> Shivani
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Shivani
> >>
> >>
> >>
> >> --
> >> Shivani
>
>
>
> --
> Shivani
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openinfosecfoundation.org/pipermail/outreachy/attachments/20190330/5c32a8a8/attachment-0001.html>