[OISF/outreachy] Issue #3825 - Some questions

[Victor Julien]

Hi Juliana,

On 18-10-2020 19:50, Juliana Fajardini Reichow via Outreachy wrote:
> I am checking task Optimization 3825: Defining only one basic rust Files 
> structure <https://redmine.openinfosecfoundation.org/issues/3825>, and I 
> need some guidance/clarification:
> 
>  From what I understood, the idea is to "extract" the bits of code that 
> define SMBFiles and NFSFiles (from smb/files and from nfs/nfs, 
> respectively) and that are basically the same, as stated, and create a 
> new file type, from which both could then implement.
> 
> I believe I have identified the common parts. Now, I'm not sure:
> - how I should name this type/structure (should it be File, would that 
> be too simple/confusing?)

I think just 'Files' would be ok.

> - where should I put this new type (in what directory should it go?)

rust/src/filetracker.rs or rust/src/filecontainer.rs

> - Once that is done, assuming that it is the correct approach, should I 
> also change smb/files and nfs/nfs to adapt to that, or should that be 
> left for a new separate task?

No, part of the task should be that the SMB/NFS parsers are updated. 
Otherwise we'd essentially add dead code.

A follow up could be to also convert HTTP2 which has a similar struct.

Regards,
Victor

-- 
---------------------------------------------
Victor Julien
http://www.inliniac.net/
PGP: http://www.inliniac.net/victorjulien.asc
---------------------------------------------