[OISF/outreachy] [OISF/suricata-verify] Task 3144/v1 Add dir as a visual indicator in the output (#344)

[Blithe Brandon]

Thanks Jason.

On Wed, Oct 21, 2020 at 9:10 AM Jason Ish <jason.ish at oisf.net> wrote:

> Normally I'd branch the new version from my current version.  Then
> fixup/squash commits to clean up the history so its a nice fresh patch
> against master.
>
> Thanks,
> Jason
>
>
> On 2020-10-21 9:52 a.m., Blithe Brandon via Outreachy wrote:
> > Forgot to reply all.
> >
> > ---------- Forwarded message ---------
> > From: *Blithe Brandon* <blithe.brandon at gmail.com
> > <mailto:blithe.brandon at gmail.com>>
> > Date: Wed, Oct 21, 2020 at 8:50 AM
> > Subject: Re: [OISF/suricata-verify] Task 3144/v1 Add dir as a visual
> > indicator in the output (#344)
> > To: Jason Ish <jason.ish at oisf.net <mailto:jason.ish at oisf.net>>
> >
> >
> > Thanks.
> >
> > And when I start my new branch, should I create it based on my previous
> > pr commits, or should it be based on master (prior to my commits) and
> > the previous pr commits squashed into the new pr? I think the difference
> > would be pr v1 would have some changes, and pr v2 would have either
> > those changes in its diff as well as the new changes or it would have
> > only the new changes. Thanks for your time. I want to make sure I
> > understand the flow and preferred process.
> >
> > Blithe
> >
> > On Wed, Oct 21, 2020 at 8:41 AM Jason Ish <jason.ish at oisf.net
> > <mailto:jason.ish at oisf.net>> wrote:
> >
> >     Hi Blithe,
> >
> >     Thats it exactly. Thanks.
> >
> >     To help with continuity, its useful if the new PR does something
> like:
> >
> >     Previous PR: <link>
> >     Changes from last PR:
> >     - Fix whatever...
> >
> >     Jason
> >
> >     On 2020-10-21 9:39 a.m., Blithe Brandon wrote:
> >      > Hi Jason,
> >      >
> >      > For the next steps, do we close the pr 344, have me make the
> >     changes on
> >      > a new branch (/v2), and submit a new pr?
> >      >
> >      > Thanks
> >      > Blithe
> >      >
> >      > ---------- Forwarded message ---------
> >      > From: *Jason Ish* <notifications at github.com
> >     <mailto:notifications at github.com>
> >      > <mailto:notifications at github.com <mailto:notifications at github.com
> >>>
> >      > Date: Wed, Oct 21, 2020 at 8:05 AM
> >      > Subject: Re: [OISF/suricata-verify] Task 3144/v1 Add dir as a
> visual
> >      > indicator in the output (#344)
> >      > To: OISF/suricata-verify <suricata-verify at noreply.github.com
> >     <mailto:suricata-verify at noreply.github.com>
> >      > <mailto:suricata-verify at noreply.github.com
> >     <mailto:suricata-verify at noreply.github.com>>>
> >      > Cc: Blithe Brandon <blithe.brandon at gmail.com
> >     <mailto:blithe.brandon at gmail.com>
> >      > <mailto:blithe.brandon at gmail.com
> >     <mailto:blithe.brandon at gmail.com>>>, Author
> >     <author at noreply.github.com <mailto:author at noreply.github.com>
> >      > <mailto:author at noreply.github.com
> >     <mailto:author at noreply.github.com>>>
> >      >
> >      >
> >      > Can this be changed to be like:
> >      >
> >      > |===> datasets-04-http-dns: OK ===> datasets-05-state: OK ===>
> >      > datasets-state-isnotset: SKIPPED: requires feature HAVE_NSS ===>
> >      > dcerpc/dce-gap-handling: OK ===> dcerpc/dce-logging: OK ===>
> >      > dcerpc/dcerpc-dce-iface-01: OK ===> dcerpc/dcerpc-dce-iface-02:
> >     OK ===>
> >      > dcerpc/dcerpc-dce-iface-03: OK ===> dcerpc/dcerpc-dce-iface-04:
> >     OK ===>
> >      > dcerpc/dcerpc-dce-opnum: OK ===> dcerpc/dcerpc-dcepayload: OK ===>
> >      > decode-chdlc-01: OK ===> decode-erspan-typeI-01: OK |
> >      >
> >      > Here we get rid of the 'tests' directory, we're only interested
> >     in the
> >      > path information after 'tests/'.
> >      >
> >      >
> >
> >
> > _______________________________________________
> > Outreachy mailing list
> > Outreachy at lists.openinfosecfoundation.org
> > https://lists.openinfosecfoundation.org/listinfo/outreachy
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openinfosecfoundation.org/pipermail/outreachy/attachments/20201021/528ee719/attachment-0001.html>