[Oisf-devel] [RFC PATCH 0/7] Coccinelle test and make check

[Eric Leblond]

This patchset contains some various modifications:
 * Patch 1 fixes some Packet initialisation
 * Patch 2 and 3 add coccinelle checking to 'make check'
 * Patch 4 adds suricata unittests to 'make check'
 * Patch 5 and 6 are functions substitution 
 * Patch 7 try to fix an issue discussed below

Patch 4 adds a run of suricata unittests against the default
configuration file. This is interesting as suricata is not
able to pass the unittest with this default configuration.
Patch 7 is a try to have the some structures reinitialised
between unittests. The solution may be not optimal as it does
not fix the problem at the root (there exists paths which can
lead to a crash when using the API).

Without this patch, suricata is crashing at IPOnlyTestSig05.
With the patch suricata still crash on SigTest01B2g.

Patchset statistics:
 Makefile.am                          |    2 +-
 configure.in                         |   17 ++++++++++++++++-
 qa/Makefile.am                       |    1 +
 qa/coccinelle/Makefile.am            |    4 ++++
 qa/coccinelle/direct-packet.cocci    |   15 +++++++++++++++
 qa/coccinelle/pktnotset-packet.cocci |   25 +++++++++++++++++++++++++
 qa/coccinelle/run_check.sh           |   10 ++++++++++
 src/Makefile.am                      |    4 ++++
 src/app-layer-detect-proto.c         |    1 +
 src/flow.c                           |   16 ++++++++++------
 src/util-mpm-ac.c                    |   10 +++++-----
 src/util-mpm-b2g-cuda.c              |    6 +++++-
 src/util-mpm.c                       |   26 +++++++++++++-------------
 src/util-unittest-helper.c           |    5 +++++
 14 files changed, 115 insertions(+), 27 deletions(-)

BR,
--
Eric