[Oisf-devel] get pidfile config from suricata.yaml if not available in command options

[Delta Yeh]

Here is the v3 patch.
Thanks for you review.

2011/11/28 Victor Julien <victor at inliniac.net>:
> Can you make the option pid-file, instead pid_file?
>
> Also, please have a space after the # on comment lines (not for
> commented out lines).
>
> Finally, another style remark, in:
>
> +        if(pid_filename == NULL) {
> +           if(ConfGet("pid_file", &pid_filename) == 1) {
> +              SCLogInfo("Use pid file %s from config file.", pid_filename);
> +           }
> +        }
>
> please add a space between if and (, like so "if ("
>
> Can you make these changes?
>
> Thanks!
> Victor
>
>
> On 11/28/2011 10:16 AM, Delta Yeh wrote:
>> here is the v2 patch.
>>
>> 2011/11/28 Victor Julien <victor at inliniac.net>:
>>> On 11/28/2011 09:59 AM, Delta Yeh wrote:
>>>> What is the default pidfile  you prefered?
>>>
>>> /var/run/suricata.pid would make sense to me.
>>>
>>> Cheers,
>>> Victor
>>>
>>>> 2011/11/28 Victor Julien <victor at inliniac.net>:
>>>>> On 11/28/2011 09:28 AM, Delta Yeh wrote:
>>>>>> Hi all,
>>>>>>  The attachment is a patch to get pidfile config from suricata.yaml if
>>>>>>  --pidfile is not available in command options.
>>>>>>
>>>>>> I would be appreciated if someone will review it.
>>>>>
>>>>> Great idea.
>>>>>
>>>>> Two comments:
>>>>> - I don't think we need the "Info" message if no file is configure.
>>>>> - can you add an example (commented out by default) to the suricata.yaml
>>>>> with a little explanation?
>>>>>
>>>>> Thanks!
>>>>>
>>>>> --
>>>>> ---------------------------------------------
>>>>> Victor Julien
>>>>> http://www.inliniac.net/
>>>>> PGP: http://www.inliniac.net/victorjulien.asc
>>>>> ---------------------------------------------
>>>>>
>>>>> _______________________________________________
>>>>> Oisf-devel mailing list
>>>>> Oisf-devel at openinfosecfoundation.org
>>>>> http://lists.openinfosecfoundation.org/mailman/listinfo/oisf-devel
>>>>>
>>>>
>>>
>>>
>>> --
>>> ---------------------------------------------
>>> Victor Julien
>>> http://www.inliniac.net/
>>> PGP: http://www.inliniac.net/victorjulien.asc
>>> ---------------------------------------------
>>>
>>>
>
>
> --
> ---------------------------------------------
> Victor Julien
> http://www.inliniac.net/
> PGP: http://www.inliniac.net/victorjulien.asc
> ---------------------------------------------
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Get-pidfile-from-config-file-if-not-available-in-comV3.patch
Type: application/octet-stream
Size: 1460 bytes
Desc: not available
URL: <http://lists.openinfosecfoundation.org/pipermail/oisf-devel/attachments/20111128/bee283d3/attachment.obj>