[Oisf-devel] [COMMIT] OISF branch, master, updated. suricata-1.2.1-56-g337f786

[Victor Julien]

On 02/16/2012 10:31 PM, Victor Julien wrote:
> On 02/16/2012 10:28 PM, Pierre Chifflier wrote:
>> On Thu, Feb 16, 2012 at 03:18:05PM -0600, noreply at openinfosecfoundation.org wrote:
>>> commit 69b3df96fba4ebff03d89bf63c2f334dd10b0259
>>> Author: Victor Julien <victor at inliniac.net>
>>> Date:   Thu Feb 16 19:27:05 2012 +0100
>>>
>>>     Initial on the fly MD5 calculation for extracted files using libnss.
>>>
>>
>> Hi all,
>>
>> This commit adds, to my understanding, a dependency on libnss as a
>> crypto library.
>> Having a crypto backend may prove useful for other needs (compute a hash
>> of certificates, for example), but I'm wondering about the particular
>> choice of libnss. Do we have reasons for using nss vs other
>> implementations ? (nettle, openssl, polarssl) ?
>> I'm not arguing against, just mentioning that it may be important for
>> further work.
> 
> I chose libnss because it has an easy api and because the license works.
> MPL1.1/GPLv2/LGPLv2.1 if I'm not mistaken. OpenSSL is considered not to
> be compatible with our GPLv2. Didn't check the others.
> 

Btw, it's a soft dependency. If the libnss is not available, everything
should still work. Only no md5.

-- 
---------------------------------------------
Victor Julien
http://www.inliniac.net/
PGP: http://www.inliniac.net/victorjulien.asc
---------------------------------------------