[Oisf-devel] Last checking faster on Tilera...

[Tom DeCanio]

commit 0150e66ede787dd0b164d5d4a3195f
69dabc7b23
Author: Victor Julien <victor at inliniac.net>
Date:   Fri Mar 9 18:31:46 2012 +0100

   flow engine: improve scalability

   Major redesign of the flow engine. Remove the flow queues that turned
   out to be major choke points when using many threads. Flow manager now
   walks the hash table directly. Simplify the way we get a new flow in
   case of emergency.

Victor;

I assume this is the cause of a speed up on Tilera.  One minor thing.

Would you mind making one minor change.  It appears that Tilera can't do
atomic mask operations on an unsigned character, so I had to do the
following.  If you change it everywhere it avoids another #ifdef for Tilera.

--- a/src/flow-manager.c
+++ b/src/flow-manager.c
@@ -63,7 +63,11 @@
 /* Run mode selected at suricata.c */
 extern int run_mode;

+#ifdef __tile__
+SC_ATOMIC_EXTERN(unsigned int, flow_flags);
+#else
 SC_ATOMIC_EXTERN(unsigned char, flow_flags);
+#endif

 /* 1 seconds */
 #define FLOW_NORMAL_MODE_UPDATE_DELAY_SEC 1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openinfosecfoundation.org/pipermail/oisf-devel/attachments/20120309/c226ef4d/attachment-0002.html>