[Oisf-devel] [PATCH] Added request length to custom HTTP logging

[Victor Julien]

On 05/26/2013 12:03 PM, I. Sanchez wrote:
> Hi,
> 
> The patch is included in the Pull Request 377 regarding feature #602
> 
> https://github.com/inliniac/suricata/pull/377
> https://redmine.openinfosecfoundation.org/issues/602

I don't see Mathews commit in the PR, how did you merge it?

Or did you mean that you already implemented the same thing yourself?

Cheers,
Victor

> 
> Cheers,
> 
>   Ignacio
> 
> 
> 
> 
> On Sun, May 26, 2013 at 6:26 AM, <mathewm at sdf.lonestar.org
> <mailto:mathewm at sdf.lonestar.org>> wrote:
> 
>     On Thu, 28 Mar 2013 10:37:10 +0100, Victor Julien
>     <victor at inliniac.net <mailto:victor at inliniac.net>> wrote:
> 
>         On 03/23/2013 10:46 AM, mathewm at sdf.lonestar.org
>         <mailto:mathewm at sdf.lonestar.org> wrote:
> 
>             Added request length to custom HTTP logging
> 
>             Custom HTTP logging currently provides access to the HTTP
>             response
>             length (via %B in the custom log format string), but not the
>             request
>             length. The request length can be very valuable.
> 
>             I've modified log-httplog.c to provide access to libhtp's
>             request_message_len, via %b in the custom log format.
> 
> 
>         Interesting addition. Was going to apply it, but my git rejects
>         it. Can
>         you retry sending it against the current master, or attach a "git
>         format-patch -1" file? A github pr works as well.
> 
>         Cheers,
>         Victor
> 
> 
>     Sorry for the delay, I need to pay more attention to my email!
> 
>     A corrected patch file is attached, which I managed to successfully
>     test locally so with any luck this one will be OK.
> 
>     Cheers
> 
>     Mat
>     _______________________________________________
>     Suricata IDS Devel mailing list:
>     oisf-devel at openinfosecfoundation.org
>     <mailto:oisf-devel at openinfosecfoundation.org>
>     Site: http://suricata-ids.org | Participate:
>     http://suricata-ids.org/participate/
>     List:
>     https://lists.openinfosecfoundation.org/mailman/listinfo/oisf-devel
>     Redmine: https://redmine.openinfosecfoundation.org/
> 
> 
> 
> 
> _______________________________________________
> Suricata IDS Devel mailing list: oisf-devel at openinfosecfoundation.org
> Site: http://suricata-ids.org | Participate: http://suricata-ids.org/participate/
> List: https://lists.openinfosecfoundation.org/mailman/listinfo/oisf-devel
> Redmine: https://redmine.openinfosecfoundation.org/
> 


-- 
---------------------------------------------
Victor Julien
http://www.inliniac.net/
PGP: http://www.inliniac.net/victorjulien.asc
---------------------------------------------