[Oisf-devel] detect-engine.c:336: Possible bad if test ?

[David Binderman]

hello there,

I recently ran the source code of suricata-1.4.6 through
the static analysis checker cppcheck.

It said

[detect-engine.c:336]: (warning) Logical conjunction always evaluates to false: alproto <= 0 && alproto>= 14.

Source code is

    if ((list == NULL) ||
        (alproto <= ALPROTO_UNKNOWN && alproto>= ALPROTO_FAILED) ||

Suggest swap && for ||

Regards

David Binderman