[Oisf-devel] Spliting large detect.c file

[Kenneth Steele]

No rush on the change.

-Ken

-----Original Message-----
From: Anoop Saldanha [mailto:anoopsaldanha at gmail.com] 
Sent: Friday, September 06, 2013 11:36 AM
To: Kenneth Steele
Cc: Oisf-devel at openinfosecfoundation.org
Subject: Re: [Oisf-devel] Spliting large detect.c file

On Fri, Sep 6, 2013 at 8:49 PM, Kenneth Steele <ken at tilera.com> wrote:
> I’m looking into splitting detect.c into smaller files, since it is 
> now over 11K lines. The original thought was to split out SIMD 
> implementations into their own files, but that is a small fraction of 
> the total lines of the file.
>
>
>
> I think it might be more logical to split the file based on if the 
> functions are used at run-time or for building the signature structures.
>
>
>
> Thoughts?
>
>

Yeah, that would make sense, although it would better to pick a period when we are not working on stuff that has significant changes in that file.  Rebase would then be out of question and requires manual editing.

I currently have uncommited code that depends on the file.

--
-------------------------------
Anoop Saldanha
http://www.poona.me
-------------------------------