[Oisf-devel] [COMMIT] OISF branch, master, updated. suricata-2.0beta2-83-g32271bd

noreply at openinfosecfoundation.org noreply at openinfosecfoundation.org
Mon Jan 20 12:22:42 UTC 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OISF".

The branch, master has been updated
       via  32271bdb66b5d6bee49b9c96c26c144a0532e533 (commit)
       via  28f14b1ed38ab2bbf987f706bd65d81d75540b38 (commit)
       via  b57ac888f8ee7a87461c77c6d114fd80917c7079 (commit)
       via  7d104fde1d7340a489546b46e5593e0d60efd66f (commit)
      from  84f14438c36e070860cb11b693463f5aea4ed851 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 32271bdb66b5d6bee49b9c96c26c144a0532e533
Author: Victor Julien <victor at inliniac.net>
Date:   Mon Jan 20 12:42:59 2014 +0100

    app-layer-ssl: fix unusual memory leak
    In some cases the TLS state pointers to subject and issuerdn could
    be overwritten by a new memory allocation, causing us to loose
    track of the old.
    This has been observed in the case of improper VLAN handling, where
    it was suspected that multiple unrelated TLS streams were mangled

commit 28f14b1ed38ab2bbf987f706bd65d81d75540b38
Author: Victor Julien <victor at inliniac.net>
Date:   Mon Jan 20 10:49:55 2014 +0100

    app-layer-ssl: style fixes
    Coding style fixes for TLS handshake parser.

commit b57ac888f8ee7a87461c77c6d114fd80917c7079
Author: Victor Julien <victor at inliniac.net>
Date:   Mon Jan 20 10:42:12 2014 +0100

    app-layer-ssl: code cleanup
    Don't alloc a void ptr and then cast in every operation. Instead,
    alloc a SSLState ptr and only case to void on returning the ptr.

commit 7d104fde1d7340a489546b46e5593e0d60efd66f
Author: Eric Leblond <eric at regit.org>
Date:   Mon Jan 20 10:41:28 2014 +0100

    util-device: use safe tailq foreach
    The loop is freeing elements so we need to use the safe version
    This fixes a valgrind error:
     Thread 1 Suricata-Main:
     Invalid read of size 8
        at 0x8E129C: LiveDeviceListClean (util-device.c:167)
        by 0x89B742: main (suricata.c:2284)
      Address 0x8382988 is 24 bytes inside a block of size 40 free'd
        at 0x4C2A70C: free (vg_replace_malloc.c:468)
        by 0x8E1297: LiveDeviceListClean (util-device.c:179)
        by 0x89B742: main (suricata.c:2284)


Summary of changes:
 src/app-layer-ssl.c           |   10 +++---
 src/app-layer-tls-handshake.c |   58 ++++++++++++++++++++++------------------
 src/util-device.c             |    4 +-
 3 files changed, 39 insertions(+), 33 deletions(-)


More information about the Oisf-devel mailing list