[Oisf-devel] [COMMIT] OISF branch, master, updated. suricata-3.2-33-g87b5bf9

OISF Git noreply at openinfosecfoundation.org
Tue Jan 17 14:30:15 UTC 2017


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OISF".

The branch, master has been updated
       via  87b5bf9541acc5bb3b64bf667a31b90f9fd6e075 (commit)
       via  d09cd16c8c0be79c02422ffc86297709e150421a (commit)
       via  a10a9220cf8f9072b6c3ad771525a333ab990f8c (commit)
       via  dfbfb50f6409a4c380f233706402ded243155392 (commit)
       via  5b1de57d732f1c938cd3b781059d79ca974f2e0c (commit)
       via  b0de5ad1a848e75ee4c3245c124ccef2343fde7e (commit)
       via  fe4e119278a09185076fa25f22f7ad6ed5d0c3ea (commit)
       via  98e8b13bf085ee7aed42cf938de07e6f3c4bccbe (commit)
       via  bcdbd12839859910c7876104fcdd15abd4e84175 (commit)
       via  c35c18a7975e13412a19d76e4c907c15fd95951c (commit)
      from  586774203f69131baad05bb57c5627b239e9a9d6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 87b5bf9541acc5bb3b64bf667a31b90f9fd6e075
Author: Jason Ish <ish at unx.ca>
Date:   Mon Jan 16 10:44:19 2017 -0600

    proto detect - fix coverity CID 1204325
    
    CID 1204325 (#1 of 1): Logically dead code (DEADCODE)
    dead_error_line: Execution cannot reach this statement: mask = 0U;.
    433        mask = 0;
    
    additionally, mask is initialized to 0

commit d09cd16c8c0be79c02422ffc86297709e150421a
Author: Jason Ish <ish at unx.ca>
Date:   Mon Jan 16 10:38:08 2017 -0600

    template logger - fix coverity CID 1324964
    
    null: At condition templatejs != NULL, the value of templatejs must be
    NULL.
    dead_error_condition: The condition templatejs != NULL cannot be true.
    113    if (templatejs != NULL) {
    CID 1324964 (#1 of 1): Logically dead code (DEADCODE)
    dead_error_line: Execution cannot reach this statement:
    json_decref(templatejs);.
    114        json_decref(templatejs);
    115    }

commit a10a9220cf8f9072b6c3ad771525a333ab990f8c
Author: Jason Ish <ish at unx.ca>
Date:   Mon Jan 16 10:34:19 2017 -0600

    dns (tcp) - fix coverity CIDs 1374306, 1374305
    
    CID 1374306 (#1 of 1): Dereference before null check (REVERSE_INULL)
    check_after_deref: Null-checking dns_state suggests that it may be null,
    but it has already been dereferenced on all paths leading to the check.
    585    if (dns_state != NULL && f != NULL) {
    586        dns_state->last_req = f->lastts;
    587    }
    
    CID 1374305 (#1 of 1): Dereference before null check (REVERSE_INULL)
    check_after_deref: Null-checking dns_state suggests that it may be null,
    but it has already been dereferenced on all paths leading to the check.
    366    if (dns_state != NULL && f != NULL) {
    367        dns_state->last_req = f->lastts;
    368    }

commit dfbfb50f6409a4c380f233706402ded243155392
Author: Jason Ish <ish at unx.ca>
Date:   Mon Jan 16 10:31:01 2017 -0600

    dns (tcp) - fix coverity cid 1374307
    
    CID 1374307 (#1 of 1): Dereference before null check (REVERSE_INULL)
    check_after_deref: Null-checking dns_state suggests that it may be null,
    but it has already been dereferenced on all paths leading to the check.
    317    if (dns_state != NULL && f != NULL) {
    318        dns_state->last_resp = f->lastts;
    319    }

commit 5b1de57d732f1c938cd3b781059d79ca974f2e0c
Author: Eric Leblond <eric at regit.org>
Date:   Tue Jan 10 14:46:48 2017 -0800

    detect-parse: simplify port prefiltering
    
    Regular expression was not matching some authorized setting like
    "![1234, 1235]". This patch simplify the regexp to match on
    possible character and let the port parsing code handle the
    complete verification.

commit b0de5ad1a848e75ee4c3245c124ccef2343fde7e
Author: Jason Ish <ish at unx.ca>
Date:   Mon Jan 9 15:13:16 2017 -0600

    dns: increment tx id when allocated during response

commit fe4e119278a09185076fa25f22f7ad6ed5d0c3ea
Author: Victor Julien <victor at inliniac.net>
Date:   Mon Jan 16 16:00:25 2017 +0100

    common: improve BUG_ON
    
    When BUG_ON is a wrapper for assert(), we risk getting rid of certain
    code lines. Assert is a no-op when NDEBUG is defined.
    
    This patch defines an alternate path for BUG_ON that exits after
    printing an error.
    
    Bug #2003.

commit 98e8b13bf085ee7aed42cf938de07e6f3c4bccbe
Author: Andreas Herz <andi at geekosphere.org>
Date:   Fri Jan 13 23:44:57 2017 +0100

    decode-icmpv6: add missing types
    
    There have been some ICMPv6 types missing within the DecodeICMPV6 that
    are added by this commit and the code check is adjusted to always use
    the DEFINE.

commit bcdbd12839859910c7876104fcdd15abd4e84175
Author: Jason Ish <ish at unx.ca>
Date:   Tue Dec 20 15:37:33 2016 -0600

    dns (tcp): register a to_client (response) probing parser
    
    Just a minimal parser to make sure the data contains at
    least a header.

commit c35c18a7975e13412a19d76e4c907c15fd95951c
Author: Jason Ish <ish at unx.ca>
Date:   Tue Dec 20 14:50:58 2016 -0600

    app-layer: support to server and to client probing parsers
    
    When registering a probing parser allow to_server and
    to_client parsers to be registered. Previously the
    probing parser may be called for both directions which
    in some cases works OK, but in others can cause
    the to_client side to be detected as failed.

-----------------------------------------------------------------------

Summary of changes:
 src/app-layer-detect-proto.c | 112 ++++++++++++++++++----------------
 src/app-layer-detect-proto.h |   6 +-
 src/app-layer-dnp3.c         |   4 +-
 src/app-layer-dns-common.c   |   1 +
 src/app-layer-dns-tcp.c      |  34 +++++++++--
 src/app-layer-dns-udp.c      |   9 +--
 src/app-layer-enip.c         |  16 ++---
 src/app-layer-modbus.c       |   4 +-
 src/app-layer-smb.c          |   8 +--
 src/app-layer-ssl.c          |   4 +-
 src/app-layer-template.c     |   6 +-
 src/decode-icmpv6.c          | 141 ++++++++++++++++++++++++++++++++++++++++---
 src/decode-icmpv6.h          |  23 +++++++
 src/detect-parse.c           |   6 +-
 src/output-json-template.c   |   3 -
 src/suricata-common.h        |  28 +++++----
 16 files changed, 292 insertions(+), 113 deletions(-)


hooks/post-receive
-- 
OISF


More information about the Oisf-devel mailing list