[OISF/outreachy] PR 344 for issue 3144 add dir as a visual indicator

[Blithe Brandon]

Thanks Jason.

That makes sense; I will definitely try practicing some first.

Blithe
On Oct 19, 2020, 4:17 PM -0700, Jason Ish via Outreachy <outreachy at lists.openinfosecfoundation.org>, wrote:
> Hello Blithe,
>
> On 2020-10-19 5:11 p.m., Blithe Brandon via Outreachy wrote:
> > Hi,
> >
> > I submitted a pull request #344. It contains two commits. The second one
> > was to clean up a non-ascii char I inadvertently inserted in the file. I
> > read that we should squash multiple commits if they are related. I’ll
> > read up more about that for next time.
>
> Yes, please squash these or do a "fixup". The way I do this is
> something like "git rebase -i HEAD~9", then change a subsequent commit
> to "fixup", and exit. It will merge the 2 together. Squash works as
> well. Of course, there are probably multiple ways to do this.
>
> Not that this is destructive.. Create a new branch to try this out if
> you are not used to it already.
>
> >
> > While working on suricata-verify, I saw some code I’d like to refactor,
> > as well as making some changes to follow pep8 guidelines. I’d also be
> > interested in converting it from python 2.7 to python 3.8. What is the
> > best way to go about this? Or should I stick with the current issues?
>
> I'd suggest to stick with the current issues. We still run
> Suricata-Verify on some Linux distributions where Python 2.7 is still
> the default. Even thought Python may have EOL'd Python 2.7, Linux
> distributions like CentOS 7 will continue to support it until 2024 or so.
>
> Thanks,
> Jason
> _______________________________________________
> Outreachy mailing list
> Outreachy at lists.openinfosecfoundation.org
> https://lists.openinfosecfoundation.org/listinfo/outreachy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openinfosecfoundation.org/pipermail/outreachy/attachments/20201019/277637ae/attachment.html>