[OISF/outreachy] Claim new issue

[Juliana Fajardini Reichow]

On Thu, Oct 22, 2020, 7:16 AM Sumera Priyadarsini <sylphrenadin at gmail.com>
wrote:

>
>
> On Thu, 22 Oct, 2020, 2:18 AM Juliana Fajardini Reichow, <
> jufajardini at gmail.com> wrote:
>
>>
>>
>> Le mer. 21 oct. 2020 à 15:37, Sumera Priyadarsini via Outreachy <
>> outreachy at lists.openinfosecfoundation.org> a écrit :
>>
>>>
>>>
>>> On Tue, Oct 20, 2020 at 11:03 PM Sumera Priyadarsini <
>>> sylphrenadin at gmail.com> wrote:
>>>
>>>>
>>>>
>>>> On Tue, Oct 20, 2020 at 8:25 PM Shivani Bhardwaj <
>>>> sbhardwaj at openinfosecfoundation.org> wrote:
>>>>
>>>>> On Tue, Oct 20, 2020 at 7:54 PM Sumera Priyadarsini
>>>>> <sylphrenadin at gmail.com> wrote:
>>>>> >
>>>>> > Yes, I tried working on 4.1.9 only. Is there any way I can work on
>>>>> rev 8709a20d as in the bug?  If I do a git checkout <hash>  then it just
>>>>> takes me back to when the commit was made i.e to a previous version
>>>>> > which results in build errors. :(
>>>>> >
>>>>> So, just for future references, if a bug report exists for any rev in
>>>>> a branch it would likely exist in the latest version of that branch
>>>>> too.
>>>>>
>>>>
>>>> I will keep this in mind, thanks!
>>>>
>>>>
>>>>> For this one, just heard from our QA lead, it is not reproducible
>>>>> anymore so you aren't doing anything wrong. :) Maybe it was fixed and
>>>>> somebody forgot to close the issue. This does not happen too often but
>>>>> since we do it manually, there is always a chance.
>>>>>
>>>> Please make sure to add this redmine issue as a contribution when you
>>>>> record them on the Outreachy dashboard.
>>>>>
>>>>> I will do that :D
>>>>
>>>> regards,
>>>> sumera
>>>>
>>>>> --
>>>>> Shivani
>>>>> Junior Developer, OISF
>>>>>
>>>>
>>> Hi Shivani,
>>>
>>> I have made a PR <https://github.com/OISF/suricata/pull/5503> for
>>> #4067. Some tests seem to be failing,but I am not sure why. Please let me
>>> know what changes I should make.
>>>
>>
>> Hi Sumera,
>>
>> Sorry for jumping in, I saw you mentioned your PR, so got curious and
>> checked the details for the tests. I saw that you said you couldn't run
>> clang at your computer, at the moment. Since today was my first day using
>> clang to check my code, I guess I'm still eager to test it, so I've taken
>> the liberty to copy your code and run it.
>>
>> This was the result, it seems that the lines got too long (this happened
>> to me as well):
>>
>> [image: image.png]
>>
>> From what I understand, it seems that applying those changes would fix
>> the code formatting issue... I hope that's of any help!
>>
>> Kind regards,
>> Juliana
>>
>>
>
> Hi Juliana,
>
> Thanks so much for helping me out! It seems like it is because of line
> length exceeding 100 characters. I thought it'd look more compact this way,
> but I'll change it.
>

Hi Sumera,

Glad to be of help! If you ever need to run clang again and I'm around,
I'll happily do it :)

Juliana


> Warm regards,
> Sumera
>
>
>
>>> I came across issue #1065
>>> <https://redmine.openinfosecfoundation.org/issues/1065> and would like
>>> to claim it, if okay.  The issue asks to introduce the vlan id keyword, but
>>> there already seems to be a vlan_id variable in the code.
>>> Can you give me a bit more context on how I should start working on this?
>>>
>>> regards,
>>> Sumera
>>> _______________________________________________
>>> Outreachy mailing list
>>> Outreachy at lists.openinfosecfoundation.org
>>> https://lists.openinfosecfoundation.org/listinfo/outreachy
>>>
>>
>>
>> --
>> Juliana Fajardini Reichow
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openinfosecfoundation.org/pipermail/outreachy/attachments/20201022/e5320ec0/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 154247 bytes
Desc: not available
URL: <http://lists.openinfosecfoundation.org/pipermail/outreachy/attachments/20201022/e5320ec0/attachment-0001.png>