[Oisf-devel] patch to support pfring bpf filter

[Eric Leblond]

Hello,

Le vendredi 28 octobre 2011 à 15:34 +0800, Delta Yeh a écrit :
> Hi all,
>   The attachment is the patch to support pfring bpf filter.
> I would be appreciated if someone will review it.

Looks almost clean but two things:
      * Whitespace issue and code formatting (check empty line, and put
        space in syntax like "if(pfconf->bpf_filter){"
      * You need to protect pfring_set_bpf_filter call in an #ifdef or
        compilation will failed with older pfring library.

If we omit this two points, it looks really correct.

BR,
--
Eric Leblond

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openinfosecfoundation.org/pipermail/oisf-devel/attachments/20111028/ec624116/attachment.sig>