[Oisf-devel] patch to support pfring bpf filter
Delta Yeh
delta.yeh at gmail.com
Fri Oct 28 14:31:30 UTC 2011
Here is the v2 patch.
Follow your advice.
2011/10/28 Eric Leblond <eric at regit.org>:
> Hello,
>
> Le vendredi 28 octobre 2011 à 15:34 +0800, Delta Yeh a écrit :
>> Hi all,
>> The attachment is the patch to support pfring bpf filter.
>> I would be appreciated if someone will review it.
>
> Looks almost clean but two things:
> * Whitespace issue and code formatting (check empty line, and put
> space in syntax like "if(pfconf->bpf_filter){"
> * You need to protect pfring_set_bpf_filter call in an #ifdef or
> compilation will failed with older pfring library.
>
> If we omit this two points, it looks really correct.
>
> BR,
> --
> Eric Leblond
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-pfring-bpf-filter-require-pfring-5.1-V2.patch
Type: application/octet-stream
Size: 4097 bytes
Desc: not available
URL: <http://lists.openinfosecfoundation.org/pipermail/oisf-devel/attachments/20111028/0ed63f00/attachment.obj>
More information about the Oisf-devel
mailing list