[Oisf-devel] Lack of Thread Deinitialization For Decoder Modules

[amin latifi]

Hi

I checked Suricata code and I found out that decoder thread modules don't
set ThreadDeinit member of their TmModule in tmm_modules table.

It somehow doesn't seem normal. Since, decode threads have at least one
member in their DecodeThreadVars which maybe should be deinitialized.
Actually, I realized DecodeThreadVars  contains AlpProtoDetectThreadCtx
member and the AlpProtoDetectThreadCtx variables maybe should be
deinitialized by using AlpProtoFinalize2Thread function; similar what
happens in StreamTcpThreadDeinit (StreamTcp thread deinitializing)
procedure.

According what I said, do you think the implementation of decoders'
deinitialization has been missed mistakenly? or not implementing of that
doesn't make any problem?

Thanks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openinfosecfoundation.org/pipermail/oisf-devel/attachments/20131120/1faaf028/attachment.html>