[Oisf-users] Is this a bug?

[Victor Julien]

On 12/29/2012 03:05 AM, 郑博文 wrote:
> Hello:
>     I am reading suricata codes recently, I think the fisrt
> "ACTION_REJECT_BOTH" should change to "ACTION_REJECT_DST" in
> util-action.c file ActionOrderVal function line 56.

This is the code:

    if( (action & ACTION_REJECT) ||
        (action & ACTION_REJECT_BOTH) ||
        (action & ACTION_REJECT_DST)) {
        action = ACTION_REJECT;
    }

How do you think it should be different? If ACTION_REJECT_BOTH would be
changed to ACTION_REJECT_DST the latter would appear twice.

Cheers,
Victor

-- 
---------------------------------------------
Victor Julien
http://www.inliniac.net/
PGP: http://www.inliniac.net/victorjulien.asc
---------------------------------------------