[Oisf-devel] patch to support pfring bpf filter

[Delta Yeh]

Thanks for your review, here is the v5 patch.

2011/10/31 Eric Leblond <eric at regit.org>:
> Hello
>
> Le vendredi 28 octobre 2011 à 23:09 +0800, Delta Yeh a écrit :
>> Please ignore patch v2.
>> This is the v3 which fix compile warning when
>> HAVE_PFRING_SET_BPF_FILTER  is not defined.
>
> There is two little problems in source-pfring.c:
>      * Indentation is not correct in active part of the code (code on
>        first column and space lacking)
>      * There is no free of the pbf_filter char string in the
>        ReceivePfringThreadDeinit() function. (Have a look at ctype
>        attribute which is freed).
>
> Once this is fixed, I will run test it and ask inclusion by Victor if
> everything is fine.
>
> BR,
>
>>
>> 2011/10/28 Delta Yeh <delta.yeh at gmail.com>:
>> > Here is the v2 patch.
>> > Follow your advice.
>> >
>> > 2011/10/28 Eric Leblond <eric at regit.org>:
>> >> Hello,
>> >>
>> >> Le vendredi 28 octobre 2011 à 15:34 +0800, Delta Yeh a écrit :
>> >>> Hi all,
>> >>>   The attachment is the patch to support pfring bpf filter.
>> >>> I would be appreciated if someone will review it.
>> >>
>> >> Looks almost clean but two things:
>> >>      * Whitespace issue and code formatting (check empty line, and put
>> >>        space in syntax like "if(pfconf->bpf_filter){"
>> >>      * You need to protect pfring_set_bpf_filter call in an #ifdef or
>> >>        compilation will failed with older pfring library.
>> >>
>> >> If we omit this two points, it looks really correct.
>> >>
>> >> BR,
>> >> --
>> >> Eric Leblond
>> >>
>> >>
>> >
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-pfring-bpf-filter-require-pfring-5.1-v5.patch
Type: application/octet-stream
Size: 5102 bytes
Desc: not available
Url : http://lists.openinfosecfoundation.org/pipermail/oisf-devel/attachments/20111101/c05bb920/0001-Add-pfring-bpf-filter-require-pfring-5.1-v5.obj