[Oisf-devel] patch to support pfring bpf filter

Delta Yeh delta.yeh at gmail.com
Fri Oct 28 15:09:20 UTC 2011


Please ignore patch v2.
This is the v3 which fix compile warning when
HAVE_PFRING_SET_BPF_FILTER  is not defined.

2011/10/28 Delta Yeh <delta.yeh at gmail.com>:
> Here is the v2 patch.
> Follow your advice.
>
> 2011/10/28 Eric Leblond <eric at regit.org>:
>> Hello,
>>
>> Le vendredi 28 octobre 2011 à 15:34 +0800, Delta Yeh a écrit :
>>> Hi all,
>>>   The attachment is the patch to support pfring bpf filter.
>>> I would be appreciated if someone will review it.
>>
>> Looks almost clean but two things:
>>      * Whitespace issue and code formatting (check empty line, and put
>>        space in syntax like "if(pfconf->bpf_filter){"
>>      * You need to protect pfring_set_bpf_filter call in an #ifdef or
>>        compilation will failed with older pfring library.
>>
>> If we omit this two points, it looks really correct.
>>
>> BR,
>> --
>> Eric Leblond
>>
>>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-pfring-bpf-filter-require-pfring-5.1-v3.patch
Type: application/octet-stream
Size: 4253 bytes
Desc: not available
URL: <http://lists.openinfosecfoundation.org/pipermail/oisf-devel/attachments/20111028/47998a3b/attachment.obj>


More information about the Oisf-devel mailing list